[alsa-devel] [PATCH v2 2/7] ASoC: soc-core: care .ignore_suspend for Component suspend

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Wed Dec 18 04:59:07 CET 2019


Hi Sridharan
Cc Mark

>     From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
>    
>     Card dai_link has .ignore_suspend, and ALSA SoC cares it when suspend.
>     For example, like this
>    
>             for_each_card_rtds(card, rtd) {
>                     if (rtd->dai_link->ignore_suspend)
>                             continue;
>                     ...
>             }
>    
>     But in snd_soc_suspend(), it doesn't care about
>     it when suspending Component. This patch cares it.
> 
> Morimoto-san,
> 
> I am a bit skeptical about this change but I could be wrong.
> I am not sure if the ignore_suspend field in the DAI link
> definitions was meant to be applicable for the components as well.
> Mark/Takashi would have to confirm this.

Hmm.. from naming point of view,
it has no problem, but I'm not sure detail, either.

It is just one of cleanup patch,
thus, I have no big objection if it was not accepted.

Mark
I think this patch doesn't have effect to other patches.
You can just ignore it if you can't accept.
But, please let me know if you have some issues.
I can post v3

Thank you for your help !!
Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list