[alsa-devel] [PATCH 01/15] ASoC: soc-core: support snd_soc_dai_link_component for codec_conf

[Kuninori Morimoto]

Hi Pierre-Louis

Thank you for your feedback

> > From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> > 
> > To find codec_conf component, it is using dev_name, of_node.
> > But, we already has this kind of finding component method by
> > snd_soc_dai_link_component, and snd_soc_is_matching_component().
> > We shouldn't have duplicate implementation to do same things.
> > This patch adds snd_soc_dai_link_component support to find
> > codec_conf component.
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> 
> Thanks Morimoto-san, this looks good to me, but I couldn't resist a
> small nit-pick below.
> 
> > ---
> >   include/sound/soc.h  |  3 +++
> >   sound/soc/soc-core.c | 18 +++++++++++-------
> >   2 files changed, 14 insertions(+), 7 deletions(-)
> > 
> > diff --git a/include/sound/soc.h b/include/sound/soc.h
> > index 82e6523..dab1212 100644
> > --- a/include/sound/soc.h
> > +++ b/include/sound/soc.h
> > @@ -949,6 +949,7 @@ struct snd_soc_dai_link {
> >   #define COMP_CODEC(_name, _dai)		{ .name = _name, .dai_name = _dai, }
> >   #define COMP_PLATFORM(_name)		{ .name = _name }
> >   #define COMP_AUX(_name)			{ .name = _name }
> > +#define COMP_CODEC_CNF(_name)		{ .name = _name }
> 
> COMP_CODEC_CONF() ?
> 
> CNF is not an acronym/concept we use anywhere else, whereas codec_conf
> is pretty much the default for variable naming.

I see.
I will fixup and post v2 tomorrow.

Thank you for your help !!
Best regards
---
Kuninori Morimoto