[alsa-devel] [PATCH v2] ALSA: firewire: Use managed buffer allocation

Takashi Sakamoto o-takashi at sakamocchi.jp
Tue Dec 10 16:40:34 CET 2019


Hi,

On Mon, Dec 09, 2019 at 08:24:22PM +0100, Takashi Iwai wrote:
> Clean up the drivers with the new managed buffer allocation API.
> The superfluous snd_pcm_lib_malloc_pages() and
> snd_pcm_lib_free_pages() calls are dropped.
> 
> Signed-off-by: Takashi Iwai <tiwai at suse.de>
> ---
> v1->v2: corrected the return value to propate the error
>         initialize err variable for covering uninitialized compiler errors
> 
>  sound/firewire/bebob/bebob_pcm.c         | 11 +++--------
>  sound/firewire/dice/dice-pcm.c           | 13 ++++---------
>  sound/firewire/digi00x/digi00x-pcm.c     | 11 +++--------
>  sound/firewire/fireface/ff-pcm.c         | 11 +++--------
>  sound/firewire/fireworks/fireworks_pcm.c | 11 +++--------
>  sound/firewire/isight.c                  | 10 ++--------
>  sound/firewire/motu/motu-pcm.c           | 11 +++--------
>  sound/firewire/oxfw/oxfw-pcm.c           | 19 +++++--------------
>  sound/firewire/tascam/tascam-pcm.c       | 11 +++--------
>  9 files changed, 29 insertions(+), 79 deletions(-)

These changes are fine to me.

Acked-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>


Regards

Takashi Sakamoto


More information about the Alsa-devel mailing list