[alsa-devel] [RESEND PATCH] ASoC: intel: Add Broadwell rt5650 machine driver

[Pierre-Louis Bossart]

On 12/4/19 4:51 PM, Curtis Malainey wrote:
>>
>>> +/* ASoC machine driver for Broadwell DSP + RT5650 */
>>> +static struct snd_soc_card bdw_rt5650_card = {
>>> +     .name = "bdw-rt5650",
>>> +     .owner = THIS_MODULE,
>>
>> is this needed?
> Left over from older conventions, any harm in keeping it? All modules
> from that era appear to have it on the card.
>>
>>> +     .dai_link = bdw_rt5650_dais,
>>> +     .num_links = ARRAY_SIZE(bdw_rt5650_dais),
>>> +     .dapm_widgets = bdw_rt5650_widgets,
>>> +     .num_dapm_widgets = ARRAY_SIZE(bdw_rt5650_widgets),
>>> +     .dapm_routes = bdw_rt5650_map,
>>> +     .num_dapm_routes = ARRAY_SIZE(bdw_rt5650_map),
> 
>>> +static struct platform_driver bdw_rt5650_audio = {
>>> +     .probe = bdw_rt5650_probe,
>>> +     .remove = bdw_rt5650_remove,
>>> +     .driver = {
>>> +             .name = "bdw-rt5650",
>>> +             .owner = THIS_MODULE,
>>
>> is this needed?
> Same as above comment

I am pretty sure Coccinelle detects this pattern and would tell you the 
core takes care of the .owner for platform drivers. I can't recall for 
snd_soc_card.