[alsa-devel] [PATCH alsa-lib] ucm: Do not fail to parse configs on cards with an empty CardComponents lists

Jaroslav Kysela perex at perex.cz
Tue Dec 3 20:39:01 CET 2019


Dne 03. 12. 19 v 18:27 Hans de Goede napsal(a):
> Since the UCM profiles for all Bay- and Cherry-Trail SST cards have been
> moved over to UCM2, parsing them fails with:
> 
> ALSA lib ucm_subs.c:220:(uc_mgr_get_substituted_value) variable '${CardComponents}' is not defined in this context!
> 
> This completely breaks audio support on all Bay- and Cherry-Trail devices.
> 
> This is caused by these non-SOF ASoC using cards having an empty
> CardComponents list. Which in itself is fine, but is rejected by
> the ucm_subs.c code. This commit changes the ucm_subs code to accept
> an empty string as a valid value for CardComponents restoring audio
> functionality on these boards.

I applied this patch to the alsa-lib repo. Thank you for this fix.

				Jaroslav

-- 
Jaroslav Kysela <perex at perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.


More information about the Alsa-devel mailing list