[alsa-devel] [PATCH 1/2] sound: codecs: gtm601: add Broadmobi bm818 sound profile
Mark Brown
broonie at kernel.org
Tue Dec 3 15:32:03 CET 2019
On Mon, Dec 02, 2019 at 10:48:30AM -0700, Angus Ainslie (Purism) wrote:
> + if (np && of_device_is_compatible(np, "broadmobi,bm818"))
> + dai_driver = &bm818_dai;
Rather than having a tree of these it'd be better if...
> #if defined(CONFIG_OF)
> static const struct of_device_id gtm601_codec_of_match[] = {
> { .compatible = "option,gtm601", },
> + { .compatible = "broadmobi,bm818", },
> {},
> };
...this used the data you can provide along with the of_match as
the dai_driver so the probe function doesn't have to know about
the individual variants.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20191203/b9641cbb/attachment-0001.sig>
More information about the Alsa-devel
mailing list