[alsa-devel] [bug report] ASoC: tlv320aic31xx: configure output common-mode voltage

[Dan Carpenter]

Hello Lucas Stach,

The patch e48fdb53bd1f: "ASoC: tlv320aic31xx: configure output
common-mode voltage" from Nov 18, 2019, leads to the following static
checker warning:

	sound/soc/codecs/tlv320aic31xx.c:1519 aic31xx_configure_ocmv()
	error: uninitialized symbol 'value'.

sound/soc/codecs/tlv320aic31xx.c
  1510  static void aic31xx_configure_ocmv(struct aic31xx_priv *priv)
  1511  {
  1512          struct device *dev = priv->dev;
  1513          int dvdd, avdd;
  1514          u32 value;
  1515  
  1516          if (dev->fwnode &&
  1517              fwnode_property_read_u32(dev->fwnode, "ai31xx-ocmv", &value)) {
                    ^^^^^^^^^^^^^^^^^^^^^^^^
This test seems reversed.  If fwnode_property_read_u32() fails then
"value" can be uninitialized.

  1518                  /* OCMV setting is forced by DT */
  1519                  if (value <= 3) {
                            ^^^^^^^^^^

  1520                          priv->ocmv = value;
  1521                          return;
  1522                  }
  1523          }
  1524  
  1525          avdd = regulator_get_voltage(priv->supplies[3].consumer);
  1526          dvdd = regulator_get_voltage(priv->supplies[5].consumer);
  1527  

regards,
dan carpenter