[alsa-devel] [PATCH] ASoC: rsnd: fixup 6ch settings to 8ch

[Eugeniu Rosca]

Hello Morimoto-san,

We've been reviewing this patch in the context of Renesas-Yocto-v3.21.0
BSP integration, where it is contained as commit [1].

On Thu, Apr 25, 2019 at 03:16:58PM +0900, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> 
> rsnd need to use 8ch clock settings for 6ch for TDM.
> Otherwise, it can't work correctly.
> This patch fixup it.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> ---
>  sound/soc/sh/rcar/core.c | 18 +++++++++++++-----
>  sound/soc/sh/rcar/rsnd.h |  1 +
>  sound/soc/sh/rcar/ssi.c  |  2 ++
>  3 files changed, 16 insertions(+), 5 deletions(-)

[..]

> diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c
> index f5afab6..44bda21 100644
> --- a/sound/soc/sh/rcar/ssi.c
> +++ b/sound/soc/sh/rcar/ssi.c
> @@ -303,6 +303,8 @@ static int rsnd_ssi_master_clk_start(struct rsnd_mod *mod,
>  	if (rsnd_runtime_is_tdm_split(io))
>  		chan = rsnd_io_converted_chan(io);
>  
> +	chan = rsnd_channel_normalization(chan);
> +

Since the "chan" value is already normalized by calling:
 => rsnd_ssi_master_clk_start()
  => chan = rsnd_runtime_channel_for_ssi(io)
   => rsnd_runtime_channel_for_ssi_with_params()
    => rsnd_channel_normalization()

I was wondering if it is really required to call
rsnd_channel_normalization() second time in ssi.c for fixing the issue
described in this patch?

>  	main_rate = rsnd_ssi_clk_query(rdai, rate, chan, &idx);
>  	if (!main_rate) {
>  		dev_err(dev, "unsupported clock rate\n");

[1] https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-bsp.git/commit/?id=54721f595654
   ("ASoC: rsnd: fixup 6ch settings to 8ch")

-- 
Best Regards,
Eugeniu.