[alsa-devel] [PATCH 21/35] ASoC: Intel: Expose ACPI loading members

[Cezary Rojewski]

On 2019-08-23 21:32, Pierre-Louis Bossart wrote:
> 
>> diff --git a/sound/soc/intel/common/sst-dsp.h 
>> b/sound/soc/intel/common/sst-dsp.h
>> index 63c29bb45cf1..a2ac7998fbdb 100644
>> --- a/sound/soc/intel/common/sst-dsp.h
>> +++ b/sound/soc/intel/common/sst-dsp.h
>> @@ -166,6 +166,27 @@
>>   #define SST_PMCS_PS_MASK    0x3
>>   struct sst_dsp;
>> +struct platform_device;
> 
> that should be handled with an include, not redefining a type here.
> 

Ack.

>> +
>> +/* Descriptor for setting up SST platform data */
>> +struct sst_acpi_desc {
>> +    const char *drv_name;
>> +    struct snd_soc_acpi_mach *machines;
>> +    /* Platform resource indexes. Must set to -1 if not used */
>> +    int resindex_lpe_base;
>> +    int resindex_pcicfg_base;
>> +    int resindex_fw_base;
>> +    int irqindex_host_ipc;
>> +    int resindex_dma_base;
>> +    /* Unique number identifying the SST core on platform */
>> +    int sst_id;
>> +    /* DMA only valid when resindex_dma_base != -1*/
>> +    int dma_engine;
>> +    int dma_size;
>> +};
>> +
>> +int sst_acpi_probe(struct platform_device *pdev);
>> +int sst_acpi_remove(struct platform_device *pdev);
>>   /*
>>    * SST Platform Data.
>>