[alsa-devel] [PATCH 18/35] ASoC: Intel: Skylake: Remove window0 sst_addr fields

[Cezary Rojewski]

On 2019-08-23 21:26, Pierre-Louis Bossart wrote:
> 
> 
> On 8/22/19 2:04 PM, Cezary Rojewski wrote:
>> w0_stat_sz and w0_up_sz are Skylake-specific fields and should not be
>> part of common sst framework. The latter is also completely unused.
>> Remove both while declaring global FW register-area size, shared for all
>> SKL+ platforms.
>>
>> Signed-off-by: Cezary Rojewski <cezary.rojewski at intel.com>
>> ---
>>   sound/soc/intel/common/sst-dsp-priv.h | 2 --
>>   sound/soc/intel/skylake/bxt-sst.c     | 2 --
>>   sound/soc/intel/skylake/cnl-sst.c     | 2 --
>>   sound/soc/intel/skylake/skl-debug.c   | 2 +-
>>   sound/soc/intel/skylake/skl-sst-dsp.h | 1 +
>>   sound/soc/intel/skylake/skl-sst.c     | 2 --
>>   6 files changed, 2 insertions(+), 9 deletions(-)
>>
>> diff --git a/sound/soc/intel/common/sst-dsp-priv.h 
>> b/sound/soc/intel/common/sst-dsp-priv.h
>> index 0fe9bebcfb38..53dcd87bab44 100644
>> --- a/sound/soc/intel/common/sst-dsp-priv.h
>> +++ b/sound/soc/intel/common/sst-dsp-priv.h
>> @@ -71,8 +71,6 @@ struct sst_addr {
>>       u32 dsp_dram_offset;
>>       u32 sram0_base;
>>       u32 sram1_base;
>> -    u32 w0_stat_sz;
>> -    u32 w0_up_sz;
>>       void __iomem *lpe;
>>       void __iomem *shim;
>>       void __iomem *pci_cfg;
>> diff --git a/sound/soc/intel/skylake/bxt-sst.c 
>> b/sound/soc/intel/skylake/bxt-sst.c
>> index c7961050c2ee..641d5cf4aeb1 100644
>> --- a/sound/soc/intel/skylake/bxt-sst.c
>> +++ b/sound/soc/intel/skylake/bxt-sst.c
>> @@ -565,8 +565,6 @@ int bxt_sst_dsp_init(struct device *dev, void 
>> __iomem *mmio_base, int irq,
>>       sst->addr.shim = mmio_base;
>>       sst->addr.sram0_base = BXT_ADSP_SRAM0_BASE;
>>       sst->addr.sram1_base = BXT_ADSP_SRAM1_BASE;
>> -    sst->addr.w0_stat_sz = SKL_ADSP_W0_STAT_SZ;
>> -    sst->addr.w0_up_sz = SKL_ADSP_W0_UP_SZ;
>>       sst_dsp_mailbox_init(sst, (BXT_ADSP_SRAM0_BASE + 
>> SKL_ADSP_W0_STAT_SZ),
>>               SKL_ADSP_W0_UP_SZ, BXT_ADSP_SRAM1_BASE, SKL_ADSP_W1_SZ);
> 
> You are still using a SKL specific macro here...
> 

The following patch takes case of that. This one has only one goal: 
removal of two redundant fields from sst_dsp::addr (struct sst_addr).

>> diff --git a/sound/soc/intel/skylake/cnl-sst.c 
>> b/sound/soc/intel/skylake/cnl-sst.c
>> index 2f10076cc906..64971966af38 100644
>> --- a/sound/soc/intel/skylake/cnl-sst.c
>> +++ b/sound/soc/intel/skylake/cnl-sst.c
>> @@ -442,8 +442,6 @@ int cnl_sst_dsp_init(struct device *dev, void 
>> __iomem *mmio_base, int irq,
>>       sst->addr.shim = mmio_base;
>>       sst->addr.sram0_base = CNL_ADSP_SRAM0_BASE;
>>       sst->addr.sram1_base = CNL_ADSP_SRAM1_BASE;
>> -    sst->addr.w0_stat_sz = CNL_ADSP_W0_STAT_SZ;
>> -    sst->addr.w0_up_sz = CNL_ADSP_W0_UP_SZ;
>>       sst_dsp_mailbox_init(sst, (CNL_ADSP_SRAM0_BASE + 
>> CNL_ADSP_W0_STAT_SZ),
>>                    CNL_ADSP_W0_UP_SZ, CNL_ADSP_SRAM1_BASE,
> 
> ...and here...
> 
>> diff --git a/sound/soc/intel/skylake/skl-debug.c 
>> b/sound/soc/intel/skylake/skl-debug.c
>> index 212370bf704c..6781eac13232 100644
>> --- a/sound/soc/intel/skylake/skl-debug.c
>> +++ b/sound/soc/intel/skylake/skl-debug.c
>> @@ -173,7 +173,7 @@ static ssize_t fw_softreg_read(struct file *file, 
>> char __user *user_buf,
>>   {
>>       struct skl_debug *d = file->private_data;
>>       struct sst_dsp *sst = d->skl->dsp;
>> -    size_t w0_stat_sz = sst->addr.w0_stat_sz;
>> +    size_t w0_stat_sz = SKL_FW_REGS_SIZE;
> 
> but here it's a different macro?
> 

The following is true:
[FW_REGS][INBOX] | [OUTBOX] | [TRACES] | [PERF_COUNTERS]
   - SRAM0 -       - SRAM1 -   - SRAM2 -     - SRAM3 -

INBOX_SIZE == OUTBOX_SIZE == PAGE_SIZE
FW_REGS_SIZE == PAGE_SIZE

w0_stat == FW_REGS
w0_up == INBOX


So we come up with very simple and readable macros - two of them:
- FW_REGS_SIZE
- ADSP_MAILBOX_SIZE

and these will suffice.

>>       void __iomem *in_base = sst->mailbox.in_base;
>>       void __iomem *fw_reg_addr;
>>       unsigned int offset;
>> diff --git a/sound/soc/intel/skylake/skl-sst-dsp.h 
>> b/sound/soc/intel/skylake/skl-sst-dsp.h
>> index 9f2dae92c1c9..5a0cb7f3d57e 100644
>> --- a/sound/soc/intel/skylake/skl-sst-dsp.h
>> +++ b/sound/soc/intel/skylake/skl-sst-dsp.h
>> @@ -63,6 +63,7 @@ struct skl_dev;
>>   #define SKL_ADSP_W1_SZ            0x1000
>> +#define SKL_FW_REGS_SIZE        PAGE_SIZE
>>   #define SKL_FW_STS_MASK            0xf
>>   #define SKL_FW_INIT            0x1
>> diff --git a/sound/soc/intel/skylake/skl-sst.c 
>> b/sound/soc/intel/skylake/skl-sst.c
>> index e9a7b2509b35..7e63c91cea54 100644
>> --- a/sound/soc/intel/skylake/skl-sst.c
>> +++ b/sound/soc/intel/skylake/skl-sst.c
>> @@ -535,8 +535,6 @@ int skl_sst_dsp_init(struct device *dev, void 
>> __iomem *mmio_base, int irq,
>>       sst->addr.shim = mmio_base;
>>       sst->addr.sram0_base = SKL_ADSP_SRAM0_BASE;
>>       sst->addr.sram1_base = SKL_ADSP_SRAM1_BASE;
>> -    sst->addr.w0_stat_sz = SKL_ADSP_W0_STAT_SZ;
>> -    sst->addr.w0_up_sz = SKL_ADSP_W0_UP_SZ;
>>       sst_dsp_mailbox_init(sst, (SKL_ADSP_SRAM0_BASE + 
>> SKL_ADSP_W0_STAT_SZ),
>>               SKL_ADSP_W0_UP_SZ, SKL_ADSP_SRAM1_BASE, SKL_ADSP_W1_SZ);
>>