[alsa-devel] [PATCH resend 08/11] ASoC: soc-core: initialize list at one place
Kuninori Morimoto
kuninori.morimoto.gx at renesas.com
Tue Aug 20 07:05:20 CEST 2019
From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
Initialize component related list at random place is very difficult
to read. This patch initialize it at snd_soc_component_initialize().
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan at linux.intel.com>
---
v2 -> v3
- add Ranjani's Reviewed-by
sound/soc/soc-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index f7fb114..39248e2 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1268,7 +1268,6 @@ static int soc_probe_component(struct snd_soc_card *card,
component->card = card;
dapm->card = card;
- INIT_LIST_HEAD(&component->card_list);
INIT_LIST_HEAD(&dapm->list);
soc_set_name_prefix(card, component);
@@ -2644,6 +2643,8 @@ static int snd_soc_component_initialize(struct snd_soc_component *component,
struct snd_soc_dapm_context *dapm;
INIT_LIST_HEAD(&component->dai_list);
+ INIT_LIST_HEAD(&component->dobj_list);
+ INIT_LIST_HEAD(&component->card_list);
mutex_init(&component->io_mutex);
component->name = fmt_single_name(dev, &component->id);
@@ -2729,7 +2730,6 @@ static void snd_soc_component_add(struct snd_soc_component *component)
/* see for_each_component */
list_add(&component->list, &component_list);
- INIT_LIST_HEAD(&component->dobj_list);
mutex_unlock(&client_mutex);
}
--
2.7.4
More information about the Alsa-devel
mailing list