[alsa-devel] [PATCH] ALSA: hda - Fixes inverted Conexant GPIO mic mute led

Takashi Iwai tiwai at suse.de
Thu Aug 15 07:58:32 CEST 2019


On Thu, 15 Aug 2019 03:38:24 +0200,
<jeronimo at borque.com.ar> wrote:
> 
> From: Jeronimo Borque <jeronimo at borque.com.ar>
> 
> "enabled" parameter historically referred to the device input or
> output, not to the led indicator. After the changes added with the
> led helper functions the mic mute led logic refers to the led and not
> to the mic input which caused led indicator to be negated (Mic mute
> led was on when the input enabled) Fixing it in the call to
> cxt_update_gpio_led at the cxt_gpio_micmute_update hook.
> Maybe more changes are required to be consistent everywhere.
> 
> Signed-off-by: Jeronimo Borque <jeronimo at borque.com.ar>

Could you check which value you have in "Mic Mute-LED Mode" mixer
element?  I guess it's "Follow Mute".  If so, change it to "Follow
Capture".

If this works, it means that the driver works as expected but the
problem is only about the default value.  The default value set in the
generic parser is based on other machine's standard (LED on at mic
off), while some machines might expect differently.  On such machines,
we need to set the different value initially in the quirk fixup.


thanks,

Takashi


More information about the Alsa-devel mailing list