[alsa-devel] [PATCH v2 0/3] soundwire: debugfs support for 5.4
Pierre-Louis Bossart
pierre-louis.bossart at linux.intel.com
Tue Aug 13 01:59:39 CEST 2019
This patchset enables debugfs support and corrects all the feedback
provided on an earlier RFC ('soundwire: updates for 5.4')
There is one remaining hard-coded value in intel.c that will need to
be fixed in a follow-up patchset not specific to debugfs: we need to
remove hard-coded Intel-specific configurations from cadence_master.c
(PDI offsets, etc).
Changes since v1 (Feedback from GKH)
Handle debugfs in a more self-contained way (no dentry as return or parameter)
Used CONFIG_DEBUG_FS in structures and code to make it easier to
remove if need be.
No functional change for register dumps.
Changes since RFC (Feedback from GKH, Vinod, Guennadi, Cezary, Sanyog):
removed error checks
used DEFINE_SHOW_ATTRIBUTE and seq_file
fixed copyright dates
fixed SPDX license info to use GPL2.0 only
fixed Makefile to include debugfs only if CONFIG_DEBUG_FS is selected
used static inlines for fallback compilation
removed intermediate variables
removed hard-coded constants in loops (used registers offsets and
hardware capabilities)
squashed patch 3
Pierre-Louis Bossart (3):
soundwire: add debugfs support
soundwire: cadence_master: add debugfs register dump
soundwire: intel: add debugfs register dump
drivers/soundwire/Makefile | 4 +
drivers/soundwire/bus.c | 6 ++
drivers/soundwire/bus.h | 16 +++
drivers/soundwire/bus_type.c | 3 +
drivers/soundwire/cadence_master.c | 107 ++++++++++++++++++++
drivers/soundwire/cadence_master.h | 4 +
drivers/soundwire/debugfs.c | 151 +++++++++++++++++++++++++++++
drivers/soundwire/intel.c | 121 +++++++++++++++++++++++
drivers/soundwire/slave.c | 1 +
include/linux/soundwire/sdw.h | 8 ++
10 files changed, 421 insertions(+)
create mode 100644 drivers/soundwire/debugfs.c
--
2.20.1
More information about the Alsa-devel
mailing list