[alsa-devel] [asoc:for-5.4 195/232] sound/soc/sof/intel/hda-dsp.c:360:22: error: 'hlink' undeclared

kbuild test robot lkp at intel.com
Mon Aug 12 17:34:59 CEST 2019


Hi Mark,

FYI, the error/warning still remains.

tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/broonie/sound.git for-5.4
head:   6fa4e0cae684d268d309d1b1f929d52e3df5649c
commit: c2f16a94a80497e4b28c27f9ca2cd6cd60706fb6 [195/232] Merge branch 'topic/hda-bus-ops-cleanup' of https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound into asoc-5.4
config: x86_64-randconfig-s0-08121238 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
        git checkout c2f16a94a80497e4b28c27f9ca2cd6cd60706fb6
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp at intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/kobject.h:19:0,
                    from include/linux/device.h:16,
                    from include/sound/hdaudio.h:9,
                    from include/sound/hdaudio_ext.h:5,
                    from sound/soc/sof/intel/hda-dsp.c:18:
   sound/soc/sof/intel/hda-dsp.c: In function 'hda_resume':
>> sound/soc/sof/intel/hda-dsp.c:360:22: error: 'hlink' undeclared (first use in this function)
     list_for_each_entry(hlink, &bus->hlink_list, list)
                         ^
   include/linux/list.h:577:7: note: in definition of macro 'list_for_each_entry'
     for (pos = list_first_entry(head, typeof(*pos), member); \
          ^~~
   sound/soc/sof/intel/hda-dsp.c:360:22: note: each undeclared identifier is reported only once for each function it appears in
     list_for_each_entry(hlink, &bus->hlink_list, list)
                         ^
   include/linux/list.h:577:7: note: in definition of macro 'list_for_each_entry'
     for (pos = list_first_entry(head, typeof(*pos), member); \
          ^~~
   In file included from include/linux/list.h:9:0,
                    from include/linux/kobject.h:19,
                    from include/linux/device.h:16,
                    from include/sound/hdaudio.h:9,
                    from include/sound/hdaudio_ext.h:5,
                    from sound/soc/sof/intel/hda-dsp.c:18:
>> sound/soc/sof/intel/hda-dsp.c:360:30: error: 'bus' undeclared (first use in this function)
     list_for_each_entry(hlink, &bus->hlink_list, list)
                                 ^
   include/linux/kernel.h:972:26: note: in definition of macro 'container_of'
     void *__mptr = (void *)(ptr);     \
                             ^~~
   include/linux/list.h:490:2: note: in expansion of macro 'list_entry'
     list_entry((ptr)->next, type, member)
     ^~~~~~~~~~
   include/linux/list.h:577:13: note: in expansion of macro 'list_first_entry'
     for (pos = list_first_entry(head, typeof(*pos), member); \
                ^~~~~~~~~~~~~~~~
   sound/soc/sof/intel/hda-dsp.c:360:2: note: in expansion of macro 'list_for_each_entry'
     list_for_each_entry(hlink, &bus->hlink_list, list)
     ^~~~~~~~~~~~~~~~~~~
>> sound/soc/sof/intel/hda-dsp.c:364:2: error: #else without #if
    #else
     ^~~~
>> sound/soc/sof/intel/hda-dsp.c:390:2: error: #endif without #if
    #endif
     ^~~~~

vim +/hlink +360 sound/soc/sof/intel/hda-dsp.c

747503b1813a3e Liam Girdwood 2019-04-12  334  
fd15f2f5e27214 Rander Wang   2019-07-22  335  static int hda_resume(struct snd_sof_dev *sdev, bool runtime_resume)
747503b1813a3e Liam Girdwood 2019-04-12  336  {
747503b1813a3e Liam Girdwood 2019-04-12  337  #if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA)
747503b1813a3e Liam Girdwood 2019-04-12  338  	struct hdac_bus *bus = sof_to_bus(sdev);
747503b1813a3e Liam Girdwood 2019-04-12  339  	struct hdac_ext_link *hlink = NULL;
747503b1813a3e Liam Girdwood 2019-04-12  340  #endif
747503b1813a3e Liam Girdwood 2019-04-12  341  	int ret;
747503b1813a3e Liam Girdwood 2019-04-12  342  
747503b1813a3e Liam Girdwood 2019-04-12  343  	/*
747503b1813a3e Liam Girdwood 2019-04-12  344  	 * clear TCSEL to clear playback on some HD Audio
747503b1813a3e Liam Girdwood 2019-04-12  345  	 * codecs. PCI TCSEL is defined in the Intel manuals.
747503b1813a3e Liam Girdwood 2019-04-12  346  	 */
747503b1813a3e Liam Girdwood 2019-04-12  347  	snd_sof_pci_update_bits(sdev, PCI_TCSEL, 0x07, 0);
747503b1813a3e Liam Girdwood 2019-04-12  348  
747503b1813a3e Liam Girdwood 2019-04-12  349  	/* reset and start hda controller */
747503b1813a3e Liam Girdwood 2019-04-12  350  	ret = hda_dsp_ctrl_init_chip(sdev, true);
747503b1813a3e Liam Girdwood 2019-04-12  351  	if (ret < 0) {
747503b1813a3e Liam Girdwood 2019-04-12  352  		dev_err(sdev->dev,
747503b1813a3e Liam Girdwood 2019-04-12  353  			"error: failed to start controller after resume\n");
747503b1813a3e Liam Girdwood 2019-04-12  354  		return ret;
747503b1813a3e Liam Girdwood 2019-04-12  355  	}
747503b1813a3e Liam Girdwood 2019-04-12  356  
747503b1813a3e Liam Girdwood 2019-04-12  357  	hda_dsp_ctrl_misc_clock_gating(sdev, false);
747503b1813a3e Liam Girdwood 2019-04-12  358  
747503b1813a3e Liam Girdwood 2019-04-12  359  	/* Reset stream-to-link mapping */
747503b1813a3e Liam Girdwood 2019-04-12 @360  	list_for_each_entry(hlink, &bus->hlink_list, list)
19abfefd4c7604 Takashi Iwai  2019-08-07  361  		writel(0, hlink->ml_addr + AZX_REG_ML_LOSIDV);
747503b1813a3e Liam Girdwood 2019-04-12  362  
747503b1813a3e Liam Girdwood 2019-04-12  363  	hda_dsp_ctrl_misc_clock_gating(sdev, true);
747503b1813a3e Liam Girdwood 2019-04-12 @364  #else
747503b1813a3e Liam Girdwood 2019-04-12  365  
747503b1813a3e Liam Girdwood 2019-04-12  366  	hda_dsp_ctrl_misc_clock_gating(sdev, false);
747503b1813a3e Liam Girdwood 2019-04-12  367  
747503b1813a3e Liam Girdwood 2019-04-12  368  	/* reset controller */
747503b1813a3e Liam Girdwood 2019-04-12  369  	ret = hda_dsp_ctrl_link_reset(sdev, true);
747503b1813a3e Liam Girdwood 2019-04-12  370  	if (ret < 0) {
747503b1813a3e Liam Girdwood 2019-04-12  371  		dev_err(sdev->dev,
747503b1813a3e Liam Girdwood 2019-04-12  372  			"error: failed to reset controller during resume\n");
747503b1813a3e Liam Girdwood 2019-04-12  373  		return ret;
747503b1813a3e Liam Girdwood 2019-04-12  374  	}
747503b1813a3e Liam Girdwood 2019-04-12  375  
747503b1813a3e Liam Girdwood 2019-04-12  376  	/* take controller out of reset */
747503b1813a3e Liam Girdwood 2019-04-12  377  	ret = hda_dsp_ctrl_link_reset(sdev, false);
747503b1813a3e Liam Girdwood 2019-04-12  378  	if (ret < 0) {
747503b1813a3e Liam Girdwood 2019-04-12  379  		dev_err(sdev->dev,
747503b1813a3e Liam Girdwood 2019-04-12  380  			"error: failed to ready controller during resume\n");
747503b1813a3e Liam Girdwood 2019-04-12  381  		return ret;
747503b1813a3e Liam Girdwood 2019-04-12  382  	}
747503b1813a3e Liam Girdwood 2019-04-12  383  
747503b1813a3e Liam Girdwood 2019-04-12  384  	/* enable hda bus irq */
747503b1813a3e Liam Girdwood 2019-04-12  385  	snd_sof_dsp_update_bits(sdev, HDA_DSP_HDA_BAR, SOF_HDA_INTCTL,
747503b1813a3e Liam Girdwood 2019-04-12  386  				SOF_HDA_INT_CTRL_EN | SOF_HDA_INT_GLOBAL_EN,
747503b1813a3e Liam Girdwood 2019-04-12  387  				SOF_HDA_INT_CTRL_EN | SOF_HDA_INT_GLOBAL_EN);
747503b1813a3e Liam Girdwood 2019-04-12  388  
747503b1813a3e Liam Girdwood 2019-04-12  389  	hda_dsp_ctrl_misc_clock_gating(sdev, true);
24b6ff686fce80 Zhu Yingjiang 2019-06-12 @390  #endif
747503b1813a3e Liam Girdwood 2019-04-12  391  
747503b1813a3e Liam Girdwood 2019-04-12  392  	/* enable ppcap interrupt */
747503b1813a3e Liam Girdwood 2019-04-12  393  	hda_dsp_ctrl_ppcap_enable(sdev, true);
747503b1813a3e Liam Girdwood 2019-04-12  394  	hda_dsp_ctrl_ppcap_int_enable(sdev, true);
747503b1813a3e Liam Girdwood 2019-04-12  395  

:::::: The code at line 360 was first introduced by commit
:::::: 747503b1813a3e6e4c52d9c0b4bd462b64940940 ASoC: SOF: Intel: Add Intel specific HDA DSP HW operations

:::::: TO: Liam Girdwood <liam.r.girdwood at linux.intel.com>
:::::: CC: Mark Brown <broonie at kernel.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 34275 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20190812/6db43fa7/attachment-0001.gz>


More information about the Alsa-devel mailing list