[alsa-devel] [PATCH 13/28] ASoC: soc-core: remove verbose debug message from soc_bind_dai_link()
Kuninori Morimoto
kuninori.morimoto.gx at renesas.com
Wed Aug 7 02:13:10 CEST 2019
Hi Pierre-Louis
Thank you for your feedback !!
> > @@ -864,13 +864,10 @@ static int soc_bind_dai_link(struct snd_soc_card *card,
> > if (dai_link->ignore)
> > return 0;
> > - dev_dbg(card->dev, "ASoC: binding %s\n", dai_link->name);
> > -
> > - if (soc_is_dai_link_bound(card, dai_link)) {
> > - dev_dbg(card->dev, "ASoC: dai link %s already bound\n",
> > - dai_link->name);
> > + if (soc_is_dai_link_bound(card, dai_link))
> > return 0;
> > - }
> > +
> > + dev_dbg(card->dev, "ASoC: binding %s\n", dai_link->name);
>
> If you want to reduce verbosity, I would have kept the other message
> which tells you about a configuration error. Here you are reducing the
> ability to debug really.
I thought it is verbose.
But, let's keep it, if some one need it.
Thank you for your help !!
Best regards
---
Kuninori Morimoto
More information about the Alsa-devel
mailing list