[alsa-devel] [PATCH 16/28] ASoC: soc-core: initialize rtd->list

Ranjani Sridharan ranjani.sridharan at linux.intel.com
Tue Aug 6 07:00:05 CEST 2019


On Tue, 2019-08-06 at 10:29 +0900, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> 
> No one initialize rtd->list, so far.
> Let's do it.
Morimoto-san,

I dont think this is needed. The rtd->list is not meant to be a list
but rather just as a member of the card->rtd_list. So no need to
initialize.

Thanks,
Ranjani
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> ---
>  sound/soc/soc-core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 2536ba4..2347b58 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c
> @@ -354,6 +354,7 @@ static struct snd_soc_pcm_runtime
> *soc_new_pcm_runtime(
>  	if (!rtd)
>  		return NULL;
>  
> +	INIT_LIST_HEAD(&rtd->list);
>  	INIT_LIST_HEAD(&rtd->component_list);
>  	rtd->card = card;
>  	rtd->dai_link = dai_link;



More information about the Alsa-devel mailing list