[alsa-devel] [PATCH 0/7][RFC] ASoC: modern style CPU
Kuninori Morimoto
kuninori.morimoto.gx at renesas.com
Tue Apr 16 03:42:51 CEST 2019
Hi Pierre-Louis
I have 1 question about modern style
> > > These are RFC of modern style CPU support.
> > >
> > > modern style dai_link needs CPU/Codec/Platform array and its size,
> > > but it will be very ugly code. To avoid it, 3) adds macro.
> > >
> > > 4) - 7) are sample code for switching to modern style dai_link.
> > > 4), 5) are good sample for single CPU/Codec/Platform.
> > > 6), 7) are good sample for multi Codec.
> >
> > > Almost all sound cards will get similar patch.
> > > I think these can work, but I can't test these.
> > > So, it is very useful if someone can test these.
> > > If these are all OK (= test/review), I can post patch-set
> > > for all sound cards.
> >
> > This looks basically fine to me, hopefully someone will be able to help
> > out with the testing - thanks for your persistence with this work!
I know you are already working for it for Intel
https://github.com/plbossart/sound/commits/fix/codec-legacy-dai
and, it will be conflict to my posted patch style.
https://patchwork.kernel.org/patch/10888741/
https://patchwork.kernel.org/patch/10888745/
So, I can avoid to posting patch for Intel,
then, you need to update it again for modern style CPU.
Or, I can update Intel by using above macro.
What is your opinion ?
Thank you for your help !!
Best regards
---
Kuninori Morimoto
More information about the Alsa-devel
mailing list