[alsa-devel] [PATCH] soundwire: cdns: Fix compilation error on arm64

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Mon Apr 15 14:41:33 CEST 2019


>> diff --git a/drivers/soundwire/cadence_master.c b/drivers/soundwire/cadence_master.c
>> index cb6a331f4..0b5bcc209 100644
>> --- a/drivers/soundwire/cadence_master.c
>> +++ b/drivers/soundwire/cadence_master.c
>> @@ -9,6 +9,7 @@
>>   #include <linux/delay.h>
>>   #include <linux/device.h>
>>   #include <linux/interrupt.h>
>> +#include <linux/io.h>
> 
> Why not add asm/io.h which is the header that actually defines
> readl/writel?

The vast majority of kernel code uses linux/io.h.
We use linux/io.h for SOF as well.

> 
>>   #include <linux/module.h>
>>   #include <linux/mod_devicetable.h>
>>   #include <linux/soundwire/sdw_registers.h>
>> -- 
>> 2.15.0
> 


More information about the Alsa-devel mailing list