[alsa-devel] [PATCH 1/2] regmap: soundwire: fix Kconfig select/depend issue
Pierre-Louis Bossart
pierre-louis.bossart at linux.intel.com
Fri Apr 12 16:07:41 CEST 2019
Thanks for the reviews
>> The mechanism should be
>>
>> config CODEC_XYX_SDW
>> depends on SOUNDWIRE
>> select REGMAP_SOUNDWIRE
>>
>> config REGMAP_SOUNDWIRE
>> depends on SOUNDWIRE
>> select SOUNDWIRE_BUS
>
> To be noted, in general you can't do put both depends-on and select.
> The select always wins. So the depends-on in REGMAP_SOUNDWIRE is more
> or less moot.
ok. To double-check, the example below would be legit, yes?
config CODEC_XYX_SDW
tristate "XYZ SDW Codec"
depends on SOUNDWIRE
select REGMAP_SOUNDWIRE
config REGMAP_SOUNDWIRE
select SOUNDWIRE_BUS
it'd follow the typical pattern seen in sound/soc/codecs/Kconfig:
config SND_SOC_CS4265
tristate "Cirrus Logic CS4265 CODEC"
depends on I2C
select REGMAP_I2C
Thanks
-Pierre
More information about the Alsa-devel
mailing list