[alsa-devel] [PATCH v4 4/4] ASoC: fsl_audmix: cache pdev->dev pointer

Nicolin Chen nicoleotsuka at gmail.com
Thu Apr 11 22:21:18 CEST 2019


On Wed, Apr 10, 2019 at 11:06:39AM +0000, Viorel Suman wrote:
> There should be no trouble to understand dev = pdev->dev.
> This can save some space to have more print info or save
> some wrapped lines.

Change looks fine. Ack.

> Signed-off-by: Viorel Suman <viorel.suman at nxp.com>
> Suggested-by: Nicolin Chen <nicoleotsuka at gmail.com>

I think usually Suggested-by comes above Signed-off-by.

This was originally in your change already, so you can replace:
-Suggested-by: Nicolin Chen <nicoleotsuka at gmail.com>
-Acked-by: Nicolin Chen <nicoleotsuka at gmail.com>

Just a chance for it to get resent without being a noise :)


More information about the Alsa-devel mailing list