[alsa-devel] [EXT] Re: [PATCH v2 1/3] ASoC: fsl_audmix: remove "model" attribute
Nicolin Chen
nicoleotsuka at gmail.com
Wed Apr 10 19:51:57 CEST 2019
On Wed, Apr 10, 2019 at 10:34:57AM +0000, Viorel Suman wrote:
> Hi Nicolin,
>
> On Ma, 2019-04-09 at 21:29 -0700, Nicolin Chen wrote:
> > WARNING: This email was created outside of NXP. DO NOT CLICK links or
> > attachments unless you recognize the sender and know the content is
> > safe.
> >
> >
> >
> > On Tue, Apr 09, 2019 at 11:27:39AM +0000, Viorel Suman wrote:
> > >
> > > Use "of_device_id.data" to specify the machine driver
> > > instead of "model" DTS attribute.
> > >
> > > Signed-off-by: Viorel Suman <viorel.suman at nxp.com>
> > Acked-by: Nicolin Chen <nicoleotsuka at gmail.com>
> >
> > >
> > > ---
> > > sound/soc/fsl/fsl_audmix.c | 43 +++++++++++++++++++++++-----------
> > > ---------
> > > 1 file changed, 23 insertions(+), 20 deletions(-)
> > >
> > > + priv->pdev = platform_device_register_data(&pdev->dev, mdrv,
> > > 0, NULL,
> > > + 0);
> > Would you please send a separate patch to replace "pdev->dev"?
>
> Thank you for review. Yes, will send V3.
Ah...when I said that, I was literally saying that you should
send a separate patch individually, not resend the series.
Now I see you sent v3/v4 almost at the same time as "Applied"
mails from Mark. And I am totally confused which version got
applied....
Please rebase your local tree and find out which version got
applied and then send the diff with a separate patch.
Thanks
Nicolin
More information about the Alsa-devel
mailing list