[alsa-devel] [EXT] Re: [PATCH] ASoC: fsl_asrc: replace the process_option table with function

[S.j. Wang]

Hi

> 
> 
> On Wed, Apr 10, 2019 at 08:26:59AM +0000, S.j. Wang wrote:
> > > Is it possible to update the table? It'd be way quicker to use
> > > lookup table than real-time calculation all the time. I believe you
> > > can simply calculate all the values out for 12KHz and 24KHz since
> > > you have the function. If there are certain combinations of these
> > > two not being supported, then we could mark it with a special value and
> add an if-check to error out.
> > >
> >
> > Yes,  but I think the function should be more flexible, if someday we
> > need to support Other sample rate, only need to update the list.
> 
> Given the fact that the owner of the function cannot give more comments, I
> feel the function wouldn't be very maintainable as none of us understands it
> well. On the other hand, you'll need to update the supported I/O rate lists
> anyway, so why not just update the table as well? The supported sample
> rates from ALSA are limited too. Overall, I think that continue using a lookup
> table wins.

Alsa support SNDRV_PCM_RATE_KNOT, we can define the rate that we want
To support,  and use function is more flexible, and we have use the function
Internally for long time, it is stable😊