[alsa-devel] [PATCH 1/5] ALSA: seq: Use kvmalloc() for cell pools
Takashi Iwai
tiwai at suse.de
Tue Apr 9 19:00:16 CEST 2019
Use kvmalloc() for allocating cell pools since the pool size can be
relatively small that may be covered better by slab.
Signed-off-by: Takashi Iwai <tiwai at suse.de>
---
sound/core/seq/seq_memory.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/sound/core/seq/seq_memory.c b/sound/core/seq/seq_memory.c
index 5b0388202bac..6ea4d8a5a71e 100644
--- a/sound/core/seq/seq_memory.c
+++ b/sound/core/seq/seq_memory.c
@@ -24,7 +24,7 @@
#include <linux/export.h>
#include <linux/slab.h>
#include <linux/sched/signal.h>
-#include <linux/vmalloc.h>
+#include <linux/mm.h>
#include <sound/core.h>
#include <sound/seq_kernel.h>
@@ -389,8 +389,8 @@ int snd_seq_pool_init(struct snd_seq_pool *pool)
if (snd_BUG_ON(!pool))
return -EINVAL;
- cellptr = vmalloc(array_size(sizeof(struct snd_seq_event_cell),
- pool->size));
+ cellptr = kvmalloc_array(sizeof(struct snd_seq_event_cell), pool->size,
+ GFP_KERNEL);
if (!cellptr)
return -ENOMEM;
@@ -398,7 +398,7 @@ int snd_seq_pool_init(struct snd_seq_pool *pool)
spin_lock_irqsave(&pool->lock, flags);
if (pool->ptr) {
spin_unlock_irqrestore(&pool->lock, flags);
- vfree(cellptr);
+ kvfree(cellptr);
return 0;
}
@@ -456,7 +456,7 @@ int snd_seq_pool_done(struct snd_seq_pool *pool)
pool->total_elements = 0;
spin_unlock_irqrestore(&pool->lock, flags);
- vfree(ptr);
+ kvfree(ptr);
spin_lock_irqsave(&pool->lock, flags);
pool->closing = 0;
--
2.16.4
More information about the Alsa-devel
mailing list