[alsa-devel] [PATCH] ASoC: cAVS: add device_link to HDMI audio

[Yang, Libin]

Hi Pierre,

>-----Original Message-----
>From: Pierre-Louis Bossart [mailto:pierre-louis.bossart at linux.intel.com]
>Sent: Monday, April 8, 2019 10:43 PM
>To: Yang, Libin <libin.yang at intel.com>; alsa-devel at alsa-project.org;
>tiwai at suse.de; broonie at kernel.org
>Subject: Re: [alsa-devel] [PATCH] ASoC: cAVS: add device_link to HDMI audio
>
>
>>> 2. if this is really a generic issue then shouldn't it be fixed for
>>> all users of the iDISP link? Why stop at the HDAudio machine driver?
>>
>> I will submit other patches for other machine drivers. Which HDAudio
>> machine driver do you mean?
>
>if you plan on updating other drivers, then by all means let's use a common
>set of helper functions. I see you have follow-up patches on github already,
>let's avoid copy/paste if possible if the same functionality is needed in
>multiple places.

Sure, I will do it. Thanks for suggestion.

>
>>>
>>> 3. we already have the component model to deal with interaction between
>>> i915 and audio, now we are adding a second layer. That looks clunky.
>>
>> The component model between i915 and audio is used to communicate
>> between display driver and audio driver. This patch is used to setup the
>> consumer and supplier relationship.
>
>consumer of what? it's very vague for people who haven't really looked
>into the details.

In our case, the consumer is the machine device, and it's the consumer
of the HDMI codec device. I will add the comments in the patch.

Regards,
Libin