[alsa-devel] [RFC PATCH 1/3] ASoC: core: do not unload topology in unregister_component()

[Mark Brown]

On Thu, Apr 04, 2019 at 05:30:38PM -0700, Ranjani Sridharan wrote:
> Typically, topology is loaded when the card is registered
> by the machine driver and the link components are probed.
> Therefore, it should be unloaded when the link components
> are removed. This will make the register/unregister component
> methods balanced.

>  			continue;
>  
> -		snd_soc_tplg_component_remove(component,
> -					      SND_SOC_TPLG_INDEX_ALL);
>  		snd_soc_component_del_unlocked(component);
>  		found = 1;

Isn't this a robustness fix?  It's just freeing anything that's left
over, it doesn't free specific stuff and shouldn't stop anything else
freeing that before so if we made a mistake earlier on it'll clean up
after you.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20190405/22af78e9/attachment.sig>