[alsa-devel] [PATCH 1/3] soundwire: fix style issues

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Thu Apr 4 21:37:05 CEST 2019


Thanks for the review Joe,

@@ -458,13 +458,13 @@ static int sdw_assign_device_num(struct sdw_slave 
*slave)

>>   		mutex_unlock(&slave->bus->bus_lock);
>>   		if (dev_num < 0) {
>>   			dev_err(slave->bus->dev, "Get dev_num failed: %d",
>> -								dev_num);
>> +				dev_num);
> You could also add the missing terminating '\n' to these formats like:
>
>   			dev_err(slave->bus->dev, "Get dev_num failed: %d\n",
>
Yes indeed, I just fixed that tools reported, but that is a miss. Will 
fix with a v2 (hopefully with other comments).

-Pierre



More information about the Alsa-devel mailing list