[alsa-devel] [PATCH 0/2] ASoC: topology: fix endianness issues

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Thu Apr 4 21:13:56 CEST 2019


Sparse reports dozens of issues with the topology code due to
endianness. Fix as needed.  There are still a handful of issues that I
could not figure out (see below), but at least now the logs become
usable.

The only remaining problematic files are the SST loader and Skylake
topology handling, which are likely to remain as is without any
updates.


sound/soc/soc-ops.c:657:33: warning: invalid assignment: &=
sound/soc/soc-ops.c:657:33:    left side has type unsigned short
sound/soc/soc-ops.c:657:33:    right side has type restricted __be16
sound/soc/soc-ops.c:661:33: warning: invalid assignment: &=
sound/soc/soc-ops.c:661:33:    left side has type unsigned int
sound/soc/soc-ops.c:661:33:    right side has type restricted __be32
sound/soc/soc-topology.c:616:70: warning: restricted __le32 degrades to integer
sound/soc/soc-topology.c:618:70: warning: restricted __le32 degrades to integer
sound/soc/soc-topology.c:633:60: warning: restricted __le32 degrades to integer
sound/soc/soc-topology.c:635:60: warning: restricted __le32 degrades to integer
sound/soc/soc-topology.c:637:61: warning: restricted __le32 degrades to integer
sound/soc/soc-topology.c:650:60: warning: restricted __le32 degrades to integer
sound/soc/soc-topology.c:652:60: warning: restricted __le32 degrades to integer
sound/soc/soc-topology.c:654:61: warning: restricted __le32 degrades to integer
sound/soc/soc-topology.c:2507:16: warning: restricted __le32 degrades to integer

Pierre-Louis Bossart (2):
  ASoC: topology: fix endianness issues
  ASoC: topology: fix big-endian check

 sound/soc/soc-topology.c | 295 +++++++++++++++++++++++----------------
 1 file changed, 173 insertions(+), 122 deletions(-)

-- 
2.17.1



More information about the Alsa-devel mailing list