[alsa-devel] [PATCH - hwmixvolume v2 0/7] Migrate to GTK+ 3.0 and allow python3

[Takashi Sakamoto]

Hi,

On Sep 18 2018 22:42, Emmanuel Gil Peyrot wrote:
> From: Emmanuel Gil Peyrot <linkmauve at linkmauve.fr>
> 
> hwmixvolume was one of the last few programs on my system to depend on
> PyGTK.  This series ports it to GTK+ 3.x using gobject-introspection,
> which allows it to run on Python 3.x too.
> 
> My audio card does not have stream controls so I’ve been unable to test
> whether the functionality is working properly, but from my reading of
> the documentation it should be fine.
> 
> Changes since v1:
> - Reordered tab→space patch before everything else, to make it possible
>    to merge it as is without any other change.
> - Merged fixup commits into the main switch patch, as they had no reason
>    to stand by themselves.
> - Replaced iteration on file.readlines() with file.__iter__() directly
>    (thanks Sakamoto-san).
> - Fix a typo in the README (thanks Sakamoto-san).
> - Explicit more the reason for each patch (thanks Iwai-san), except for
>    trivial ones.
> 
> Emmanuel Gil Peyrot (7):
>    hwmixvolume: use four spaces instead of one tab for indent
>    hwmixvolume: replace PyGTK with gobject-introspection
>    hwmixvolume: switch to GTK+ 3.0 and GLib 2.0
>    hwmixvolume: use a with context to open files
>    hwmixvolume: switch the shebang to python
>    hwmixvolume: add my copyright
>    hwmixvolume: mention the new dependencies in the README
> 
>   hwmixvolume/README      |   3 +-
>   hwmixvolume/hwmixvolume | 560 ++++++++++++++++++++--------------------
>   2 files changed, 283 insertions(+), 280 deletions(-)

I reviewed all of the above patches.

Reviewed-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>


Thanks

Takashi Sakamoto