[alsa-devel] [PATCH] ALSA: oxfw: fix memory leak for model-dependent data at error path
Takashi Sakamoto
o-takashi at sakamocchi.jp
Mon Sep 17 10:26:08 CEST 2018
After allocating model-dependent data, ALSA OXFW driver has memory leak
of the data at error path.
This commit releases the data at the error path.
Fixes: 6c29230e2a5f ('ALSA: oxfw: delayed registration of sound card')
Cc: <stable at vger.kernel.org> # v4.7+
Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>
---
sound/firewire/oxfw/oxfw.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/firewire/oxfw/oxfw.c b/sound/firewire/oxfw/oxfw.c
index 63b3e1ce986e..9c8c527ebff9 100644
--- a/sound/firewire/oxfw/oxfw.c
+++ b/sound/firewire/oxfw/oxfw.c
@@ -277,6 +277,8 @@ static void do_registration(struct work_struct *work)
oxfw->rx_stream_formats[i] = NULL;
}
snd_card_free(oxfw->card);
+ kfree(oxfw->spec);
+ oxfw->spec = NULL;
dev_info(&oxfw->unit->device,
"Sound card registration failed: %d\n", err);
}
--
2.17.1
More information about the Alsa-devel
mailing list