[alsa-devel] [PATCH] ASoC: max98373: usleep_range() needs include/delay.h

[Grant Grundler]

On Fri, Sep 7, 2018 at 5:11 AM Mark Brown <broonie at kernel.org> wrote:

> On Thu, Sep 06, 2018 at 05:27:28PM -0700, Grant Grundler wrote:
> > Commit ca917f9fe1a0fab added use of usleep_range() but not
> > the corresponding "include <linux/delay.h>". The result is
> > with Chrome OS won't build because warnings are forced
> > to be errors:
> >
> mnt/host/source/src/third_party/kernel/v4.4/sound/soc/codecs/max98373.c:734:2:
> error: implicit declaration of function 'usleep_range'
> [-Werror,-Wimplicit-function-declaration]
> >         usleep_range(10000, 11000);
> >         ^
>
> Note that this isn't causing a warning upstream, presumably due to an
> implicit inclusion that isn't present in the v4.4 kernel that you appear
> to be using, or gets missed due to config differences.
>

Ok. Is this just an observation or are these reasons to not accept the
change?

cheers,
grant