[alsa-devel] [PATCH 04/16] ASoC: cirrus: use devm_snd_soc_register_component()

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Tue Sep 11 02:08:59 CEST 2018


Hi Mark

Thank you for your feedback

> > @@ -422,8 +420,6 @@ static int ep93xx_ac97_remove(struct platform_device *pdev)
> >  {
> >  	struct ep93xx_ac97_info	*info = platform_get_drvdata(pdev);
> >  
> > -	snd_soc_unregister_component(&pdev->dev);
> > -
> >  	/* disable the AC97 controller */
> >  	ep93xx_ac97_write_reg(info, AC97GCR, 0);
> >  
> 
> Similar ordering thing here - it's generally fine to convert to devm_ if
> the unregister is the last thing in the remove function but otherwise
> you need to be careful.

I see.
OK, please skip it.

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list