[alsa-devel] [PATCH v2 06/12] ASoC: SOF: Add support for loading topologies

[Mark Brown]

On Fri, Aug 31, 2018 at 04:19:04PM +0100, Liam Girdwood wrote:

> +static int sof_widget_load(struct snd_soc_component *scomp, int index,
> +			   struct snd_soc_dapm_widget *w,
> +			   struct snd_soc_tplg_dapm_widget *tw)
> +{
> +	/* nothing todo atm */
> +	return 0;
> +}

> +static int sof_link_unload(struct snd_soc_component *scomp,
> +			   struct snd_soc_dobj *dobj)
> +{
> +	return 0;
> +}

Missing implementation here as well?  If these functions can sensibly be
optional shouldn't the framework support that?

> +static int sof_route_unload(struct snd_soc_component *scomp,
> +			    struct snd_soc_dobj *dobj)
> +{
> +	/* TODO: unload routes when topology is changed */
> +	return 0;
> +}

This seems like it should at least return an error.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20180903/23bd373a/attachment.sig>