[alsa-devel] [PATCH - Intervals v2 1/1] interval: Interpret (x x+1] correctly and return x+1

[Jaroslav Kysela]

Dne 24.10.2018 v 10:05 Timo Wischer napsal(a):
> On 10/24/18 09:48, Takashi Iwai wrote:
>> If it can be reproduced with the loopback driver, it makes easier to
>> debug.  But you modified something?  Then it has to be clarified at
>> first; i.e. let others reproduce your problem.  Otherwise we have no
>> merit to debug it in our side :)
> 
> Okay. Sorry for the inconvenience.

I am working on a regression which was caused with your
9bb985c382bab8c3bf83c0d23f50195288d3cf9f change:


http://git.alsa-project.org/?p=alsa-lib.git;a=commit;h=9bb985c382bab8c3bf83c0d23f50195288d3cf9f

Regression bug: https://bugzilla.redhat.com/show_bug.cgi?id=1640602

This change reordered/corrected intervals and I can confirm that
snd_interval_single() and snd_interval_value() functions must be updated
otherwise refining fails with some parameters.

Reproducer:

~/.asoundrc:

  pcm.aloop44100 {
    type rate
    slave.pcm hw:Loopback
    slave.rate 44100
  }

$ LD_PRELOAD=./src/.libs/libasound.so.2.0.0 aplay -Daloop44100 -c2  -r
44100 -fS16_LE --period-time=62500 --buffer-size=11025  -v -d 1 /dev/zero

This command works with 9bb985c382bab8c3bf83c0d23f50195288d3cf9f
reverted and with your new patch applied. It does not work only with
9bb985c382bab8c3bf83c0d23f50195288d3cf9f.

I applied your patch to alsa-lib repo:

http://git.alsa-project.org/?p=alsa-lib.git;a=commit;h=b420056604f06117c967b65d43d01536c5ffcbc9

Thanks for your work.

					Jaroslav

-- 
Jaroslav Kysela <perex at perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.