[alsa-devel] [PATCH] ASoC: nau8822: new codec driver

[Mark Brown]

On Fri, Oct 19, 2018 at 12:56:53PM +0800, AC30 CTLin0 wrote:
> On 10/18/2018 2:54 AM, Mark Brown wrote:
> > On Fri, Sep 28, 2018 at 11:10:04AM +0800, David Lin wrote:

> > We're trying to get away from using set_clkdiv() as it makes it much
> > harder to use generic card drivers without specific knowledge of the
> > card.  However in this case it seems like it's mainly choosing if we
> > should use the MCLK directly or the PLL and you should be able to do
> > everything in the set_sysclk() operation - is there a reason not to do
> > that?  If not then moving to set_sysclk() would avoid problems.

> The nau8822_config_clkdiv() will be called internally by
> nau8822_hw_params(), not link to the function point (*set_clkdiv) from
> the structure "snd_soc_dai_ops".

> If nau8822_config_clkdiv() need to simplify, I will remove case
> NAU8822_CLK_PLL. The reason is using set_pll() operation can also finish
> clk configure from machine driver.

Ah, sorry - now that you mention it I think I did see that it wasn't
referenced as an actual op when I looked at a previous version which is
why I didn't mention it then.  The current code is fine, don't worry
about it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 484 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20181019/58155f13/attachment.sig>