[alsa-devel] [PATCH] ASoC: pcm3168a: remove read-only status register from snd_kcontrol_new

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Thu Oct 18 02:18:30 CEST 2018


Hi Mark

> > +#if 0
> > +	/* read-only status register needs clocks */
> >  	SOC_DOUBLE_STS("DAC1 Zero Flag", PCM3168A_DAC_ZERO, 0, 1, 1, 0),
> >  	SOC_DOUBLE_STS("DAC2 Zero Flag", PCM3168A_DAC_ZERO, 2, 3, 1, 0),
> >  	SOC_DOUBLE_STS("DAC3 Zero Flag", PCM3168A_DAC_ZERO, 4, 5, 1, 0),
> >  	SOC_DOUBLE_STS("DAC4 Zero Flag", PCM3168A_DAC_ZERO, 6, 7, 1, 0),
> > +#endif
> 
> If you're removing these just delete them, no need to leave the
> commented out stuff.  It would be good to understand why these break
> though...

OK, will send v2 patch, soon.

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list