[alsa-devel] [PATCH] ASoC: amd: Fix a NULL vs IS_ERR() check in probe
Dan Carpenter
dan.carpenter at oracle.com
Mon Nov 26 09:13:07 CET 2018
The platform_device_register_full() function doesn't return NULL, it
returns error pointers.
Fixes: 7894a7e7ea3d ("ASoC: amd: create ACP3x PCM platform device")
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
---
sound/soc/amd/raven/pci-acp3x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/amd/raven/pci-acp3x.c b/sound/soc/amd/raven/pci-acp3x.c
index c28457fd9b81..facec2472b34 100644
--- a/sound/soc/amd/raven/pci-acp3x.c
+++ b/sound/soc/amd/raven/pci-acp3x.c
@@ -97,10 +97,10 @@ static int snd_acp3x_probe(struct pci_dev *pci,
pdevinfo.size_data = sizeof(irqflags);
adata->pdev = platform_device_register_full(&pdevinfo);
- if (!adata->pdev) {
+ if (IS_ERR(adata->pdev)) {
dev_err(&pci->dev, "cannot register %s device\n",
pdevinfo.name);
- ret = -ENODEV;
+ ret = PTR_ERR(adata->pdev);
goto unmap_mmio;
}
break;
--
2.11.0
More information about the Alsa-devel
mailing list