[alsa-devel] [PATCH 2/2] ALSA: dice: unuse second stream for MIDI conformant data channel for TC Electronic models

Takashi Sakamoto o-takashi at sakamocchi.jp
Sun May 27 03:13:30 CEST 2018


At present, all of models produced by TC Electronic except for Konnekt Live
are supported with hard-coded their stream formats. Studio Konnekt 48 is
sore model to support dual streams for both directions. The second stream
has no MIDI conformant data channel in its data block. But current
implementation transfers the second stream with MIDI conformant data
channel.

This commit fixes this issue.

Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>
---
 sound/firewire/dice/dice-tcelectronic.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/sound/firewire/dice/dice-tcelectronic.c b/sound/firewire/dice/dice-tcelectronic.c
index a4cbe2da8c15..a8875d24ba2a 100644
--- a/sound/firewire/dice/dice-tcelectronic.c
+++ b/sound/firewire/dice/dice-tcelectronic.c
@@ -95,11 +95,9 @@ int snd_dice_detect_tcelectronic_formats(struct snd_dice *dice)
 	memcpy(dice->rx_pcm_chs, entry->spec->rx_pcm_chs,
 	       MAX_STREAMS * SND_DICE_RATE_MODE_COUNT * sizeof(unsigned int));
 
-	for (i = 0; i < MAX_STREAMS; ++i) {
-		if (entry->spec->has_midi) {
-			dice->tx_midi_ports[i] = 1;
-			dice->rx_midi_ports[i] = 1;
-		}
+	if (entry->spec->has_midi) {
+		dice->tx_midi_ports[0] = 1;
+		dice->rx_midi_ports[0] = 1;
 	}
 
 	return 0;
-- 
2.14.1



More information about the Alsa-devel mailing list