[alsa-devel] [PATCH v3] ASoC: ssm2305: Add amplifier driver
Mark Brown
broonie at kernel.org
Fri May 18 10:31:30 CEST 2018
On Fri, May 18, 2018 at 10:07:11AM +0200, Marco Felsch wrote:
> On 18-05-17 18:08, Mark Brown wrote:
> >
> > Please submit a followup patch which makes the entire comment a C++ one
> > rather than mixing them in the same comment block, it makes things look
> > more intentional.
> I'm a bit confused. As documented by the
> Documentation/process/license-rules.rst the license header should be a C++
> comment but for all block comments the 'normal' coding style should be
> applied. I can seperate the license header and the comment to make it
> more intentional.
> // SPDX-License-Identifier: GPL-2.0
>
> /*
> * Analog Devices SSM2305 Amplifier Driver
> *
> * Copyright (C) 2018 Pengutronix, Marco Felsch <kernel at pengutronix.de>
> */
> Is that better?
No, that still looks like a mess. Just make the whole thing a C++
comment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20180518/060fab38/attachment.sig>
More information about the Alsa-devel
mailing list