[alsa-devel] [PATCH] ALSA: usb-audio: Apply rate limit to warning messages in URB complete callback

Takashi Iwai tiwai at suse.de
Wed May 16 20:09:31 CEST 2018


retire_capture_urb() may print warning messages when the given URB
doesn't align, and this may flood the system log easily.
Put the rate limit to the message for avoiding it.

Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1093485
Signed-off-by: Takashi Iwai <tiwai at suse.de>
---
 sound/usb/pcm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
index dc2dfec9effd..20bed1c7a312 100644
--- a/sound/usb/pcm.c
+++ b/sound/usb/pcm.c
@@ -1303,7 +1303,7 @@ static void retire_capture_urb(struct snd_usb_substream *subs,
 		if (bytes % (runtime->sample_bits >> 3) != 0) {
 			int oldbytes = bytes;
 			bytes = frames * stride;
-			dev_warn(&subs->dev->dev,
+			dev_warn_ratelimited(&subs->dev->dev,
 				 "Corrected urb data len. %d->%d\n",
 							oldbytes, bytes);
 		}
-- 
2.16.3



More information about the Alsa-devel mailing list