[alsa-devel] [PATCH v2 0/2] ASoC: omap: sdma-pcm: modpost warning fix and include cleanup

Peter Ujfalusi peter.ujfalusi at ti.com
Tue May 15 08:43:33 CEST 2018


Hi,

Changes since v1:
- Changed the MODULE_LICENSE from "GPL" to "GPL v2" to match the SPDX line.

Since the sdma-pcm can be built as module it must have MODULE_LICENSE defined,
whcih I have missed:

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o
see include/linux/module.h for more information

The first patch also going to fix runtime issue with module loading:
snd_soc_sdma: Unknown symbol devm_kmalloc (err 0)
snd_soc_sdma: Unknown symbol omap_dma_filter_fn (err 0)
snd_soc_sdma: Unknown symbol snd_dmaengine_pcm_prepare_slave_config (err 0)
snd_soc_sdma: Unknown symbol devm_snd_dmaengine_pcm_register (err 0)

As these symbols are EXPORT_SYMBOL_GPL()...

Introduced by commit

  dde637f2daf1 ("ASoC: omap: Introduce the generic_dmaengine_pcm based sdma-pcm")

The second patch is kust a small adjustement for the include files.

Regards,
Peter
---
Peter Ujfalusi (2):
  ASoC: omap: sdma-pcm: Fix modpost warning
  ASoC: omap: sdma-pcm: Correction for the include files

 sound/soc/omap/sdma-pcm.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki



More information about the Alsa-devel mailing list