[alsa-devel] [PATCH 2/4] ASoC: compress: Clarify the intent of current compressed ops handling

[Charles Keepax]

On Tue, May 08, 2018 at 02:03:19PM +0530, Vinod Koul wrote:
> On 04-05-18, 12:59, Charles Keepax wrote:
> > On Thu, May 03, 2018 at 09:57:14PM +0530, Vinod Koul wrote:
> > > On Thu, Apr 26, 2018 at 05:30:05PM +0100, Charles Keepax wrote:
> > That said however, thinking about it more I do think there are
> > pretty reasonable systems that have multiple components on a
> > compressed DAI. For example I could imagine a system where you
> > have a DSP on both the AP and CODEC ends of the DAI link and
> > they split the decode doing some work on each. In that case
> > one would want calls like open and set_params to go to both
> > components.
> 
> Am not sure if we can split the decode into multiple DSPs like
> this :) Yes one can do processing and one can decode if both have
> the capability but I don't forsee that being split, so not sure
> if we need it!!!
>

I think you definitely could split the decode across multiple
DSPs like that, we have had processing split across multiple
cores for various things on the CODECs. That said "Need it"
is very strong, I would say such a system is plausible but
not something I am aware anyone is actually building right now.

I guess my thinking was that the system is basically already
supporting multiple components so it seemed like a step
backwards to rip it out given there are plausible systems were
it might be useful. And this patch is really just tidying up
the already submitted code a little rather than changing the
functionality in any substancial way.

That said if you feel strongly about it, I certainly don't
need the support in the foreseeable future. I am happy to
go back to something similar to my earlier patch that just
locates the first device with compressed ops and calls the
ops on that?  Although it might still be worth merging this
one as an intermediate tidy up in that case.

Thanks,
Charles