[alsa-devel] [PATCH 1/2] ALSA: usb-audio: fix uac control query argument

Takashi Iwai tiwai at suse.de
Fri Mar 23 10:25:37 CET 2018


On Fri, 23 Mar 2018 08:52:01 +0100,
Andrew Chant wrote:
> 
> Applying this now would be great, thank you.

OK, applied now.  Thanks!


Takashi

> 
> On Mar 23, 2018 12:48 AM, "Takashi Iwai" <tiwai at suse.de> wrote:
> 
> On Thu, 22 Mar 2018 22:39:55 +0100,
> Andrew Chant wrote:
> >
> > This patch fixes code readability and should have no functional change.
> >
> > Correct uac control query functions to account for the 1-based indexing
> > of USB Audio Class control identifiers.
> >
> > The function parameter, u8 control, should be the
> > constant defined in audio-v2.h to identify the control to be checked for
> > readability or writeability.
> >
> > This patch fixes all callers that had adjusted, and makes explicit
> > the mapping between audio_feature_info[] array index and the associated
> > control identifier.
> >
> > Signed-off-by: Andrew Chant <achant at google.com>
> 
> Looks like a nice clean up and fix.
> Would you like me applying this now, or better all together later?
> 
> 
> thanks,
> 
> Takashi
> [2  <text/html; UTF-8 (quoted-printable)>]
> 


More information about the Alsa-devel mailing list