[alsa-devel] [PATCH v2 10/21] lightnvm: Remove depends on HAS_DMA in case of platform dependency

[Madalin-cristian Bucur]

> -----Original Message-----
> From: netdev-owner at vger.kernel.org [mailto:netdev-owner at vger.kernel.org]
> On Behalf Of Geert Uytterhoeven
> Sent: Friday, March 16, 2018 3:52 PM
> To: Christoph Hellwig <hch at lst.de>; Marek Szyprowski
> <m.szyprowski at samsung.com>; Robin Murphy <robin.murphy at arm.com>;
> Felipe Balbi <balbi at kernel.org>; Greg Kroah-Hartman
> <gregkh at linuxfoundation.org>; James E . J . Bottomley
> <jejb at linux.vnet.ibm.com>; Martin K . Petersen
> <martin.petersen at oracle.com>; Andrew Morton <akpm at linux-
> foundation.org>; Mark Brown <broonie at kernel.org>; Liam Girdwood
> <lgirdwood at gmail.com>; Tejun Heo <tj at kernel.org>; Herbert Xu
> <herbert at gondor.apana.org.au>; David S . Miller <davem at davemloft.net>;
> Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com>; Stefan Richter
> <stefanr at s5r6.in-berlin.de>; Alan Tull <atull at kernel.org>; Moritz Fischer
> <mdf at kernel.org>; Wolfram Sang <wsa at the-dreams.de>; Jonathan Cameron
> <jic23 at kernel.org>; Joerg Roedel <joro at 8bytes.org>; Matias Bjorling
> <mb at lightnvm.io>; Jassi Brar <jassisinghbrar at gmail.com>; Mauro Carvalho
> Chehab <mchehab at kernel.org>; Ulf Hansson <ulf.hansson at linaro.org>; David
> Woodhouse <dwmw2 at infradead.org>; Brian Norris
> <computersforpeace at gmail.com>; Marek Vasut <marek.vasut at gmail.com>;
> Cyrille Pitchen <cyrille.pitchen at wedev4u.fr>; Boris Brezillon
> <boris.brezillon at free-electrons.com>; Richard Weinberger <richard at nod.at>;
> Kalle Valo <kvalo at codeaurora.org>; Ohad Ben-Cohen <ohad at wizery.com>;
> Bjorn Andersson <bjorn.andersson at linaro.org>; Eric Anholt <eric at anholt.net>;
> Stefan Wahren <stefan.wahren at i2se.com>
> Cc: iommu at lists.linux-foundation.org; linux-usb at vger.kernel.org; linux-
> scsi at vger.kernel.org; alsa-devel at alsa-project.org; linux-ide at vger.kernel.org;
> linux-crypto at vger.kernel.org; linux-fbdev at vger.kernel.org; linux1394-
> devel at lists.sourceforge.net; linux-fpga at vger.kernel.org; linux-
> i2c at vger.kernel.org; linux-iio at vger.kernel.org; linux-block at vger.kernel.org;
> linux-media at vger.kernel.org; linux-mmc at vger.kernel.org; linux-
> mtd at lists.infradead.org; netdev at vger.kernel.org; linux-
> remoteproc at vger.kernel.org; linux-serial at vger.kernel.org; linux-
> spi at vger.kernel.org; devel at driverdev.osuosl.org; linux-
> kernel at vger.kernel.org; Geert Uytterhoeven <geert at linux-m68k.org>
> Subject: [PATCH v2 10/21] lightnvm: Remove depends on HAS_DMA in case of
> platform dependency
> 
> Remove dependencies on HAS_DMA where a Kconfig symbol depends on
> another
> symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST".
> In most cases this other symbol is an architecture or platform specific
> symbol, or PCI.
> 
> Generic symbols and drivers without platform dependencies keep their
> dependencies on HAS_DMA, to prevent compiling subsystems or drivers that
> cannot work anyway.
> 
> This simplifies the dependencies, and allows to improve compile-testing.
> 
> Notes:
>   - FSL_FMAN keeps its dependency on HAS_DMA, as it calls set_dma_ops(),
>     which does not exist if HAS_DMA=n (Do we need a dummy? The use of
>     set_dma_ops() in this driver is questionable),

Hi,

The set_dma_ops() is no longer required in the fsl/fman, I'll send a patch to remove it.

Thanks

>   - SND_SOC_LPASS_IPQ806X and SND_SOC_LPASS_PLATFORM loose their
>     dependency on HAS_DMA, as they are selected from
>     SND_SOC_APQ8016_SBC.
> 
> Signed-off-by: Geert Uytterhoeven <geert at linux-m68k.org>
> Reviewed-by: Mark Brown <broonie at kernel.org>
> Acked-by: Robin Murphy <robin.murphy at arm.com>
> ---
> v2:
>   - Add Reviewed-by, Acked-by,
>   - Drop RFC state,
>   - Split per subsystem.
> ---
>  drivers/lightnvm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig
> index 10c08982185a572f..9c03f35d9df113c6 100644
> --- a/drivers/lightnvm/Kconfig
> +++ b/drivers/lightnvm/Kconfig
> @@ -4,7 +4,7 @@
> 
>  menuconfig NVM
>  	bool "Open-Channel SSD target support"
> -	depends on BLOCK && HAS_DMA && PCI
> +	depends on BLOCK && PCI
>  	select BLK_DEV_NVME
>  	help
>  	  Say Y here to get to enable Open-channel SSDs.
> --
> 2.7.4