[alsa-devel] [PATCH v2 10/21] lightnvm: Remove depends on HAS_DMA in case of platform dependency

[Matias Bjørling]

On 03/16/2018 02:51 PM, Geert Uytterhoeven wrote:
> Remove dependencies on HAS_DMA where a Kconfig symbol depends on another
> symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST".
> In most cases this other symbol is an architecture or platform specific
> symbol, or PCI.
> 
> Generic symbols and drivers without platform dependencies keep their
> dependencies on HAS_DMA, to prevent compiling subsystems or drivers that
> cannot work anyway.
> 
> This simplifies the dependencies, and allows to improve compile-testing.
> 
> Notes:
>    - FSL_FMAN keeps its dependency on HAS_DMA, as it calls set_dma_ops(),
>      which does not exist if HAS_DMA=n (Do we need a dummy? The use of
>      set_dma_ops() in this driver is questionable),
>    - SND_SOC_LPASS_IPQ806X and SND_SOC_LPASS_PLATFORM loose their
>      dependency on HAS_DMA, as they are selected from
>      SND_SOC_APQ8016_SBC.
> 
> Signed-off-by: Geert Uytterhoeven <geert at linux-m68k.org>
> Reviewed-by: Mark Brown <broonie at kernel.org>
> Acked-by: Robin Murphy <robin.murphy at arm.com>
> ---
> v2:
>    - Add Reviewed-by, Acked-by,
>    - Drop RFC state,
>    - Split per subsystem.
> ---
>   drivers/lightnvm/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig
> index 10c08982185a572f..9c03f35d9df113c6 100644
> --- a/drivers/lightnvm/Kconfig
> +++ b/drivers/lightnvm/Kconfig
> @@ -4,7 +4,7 @@
>   
>   menuconfig NVM
>   	bool "Open-Channel SSD target support"
> -	depends on BLOCK && HAS_DMA && PCI
> +	depends on BLOCK && PCI
>   	select BLK_DEV_NVME
>   	help
>   	  Say Y here to get to enable Open-channel SSDs.
> 

Looks good.

Reviewed-by: Matias Bjørling <mb at lightnvm.io>