[alsa-devel] [PATCH 4/5] ASoC: samsung: Document compatible strings for Odroid X/X2, Odroid XU3

[Mark Brown]

On Fri, Mar 16, 2018 at 08:37:28AM +0100, Krzysztof Kozlowski wrote:
> On Wed, Mar 14, 2018 at 5:42 PM, Sylwester Nawrocki

> > - - compatible - "hardkernel,odroid-xu3-audio" - for Odroid XU3 board,
> > + - compatible - "hardkernel,odroid-u3-audio" - for Odroid U3 board,
> > +               "hardkernel,odroid-x-audio" - for Odroid X, Odroid X2 boards,
> > +               "hardkernel,odroid-xu3-audio" - for Odroid XU3 board,
> >                 "hardkernel,odroid-xu4-audio" - for Odroid XU4 board

> These are the same so I think they should not get separate
> compatibles. By definition [2] the compatible expresses the
> compatibility with family of devices. In this case - these belong to
> the same family.

> The same applies to patch 5/5 (implementation of this).

I don't see a problem with adding the compatibles - the software
handling might be identical but it's not really causing a problem to
explicit document which board it is if people want.  It may end up
coming in useful at some point if there's some mechanical/plastics
difference which ends up being useful to handle (though that's much less
likely for dev boards like this than for finished products).  But
equally it's not essential, whatever you two decide.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20180319/c100f350/attachment.sig>