[alsa-devel] [PATCH v2 7/7] ASoC: samsung: Add HDMI audio support for Chromebook Snow

Krzysztof Kozlowski krzk at kernel.org
Mon Mar 12 08:39:11 CET 2018


On Fri, Mar 9, 2018 at 6:48 PM, Sylwester Nawrocki
<s.nawrocki at samsung.com> wrote:
> This patch updates the driver so, in addition to current DT bindings,
> the new DT bindings with cpu, codec subnodes can be used, in order to
> support sound on the HDMI interface.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki at samsung.com>
> ---
> Changes since v1:
>  - adjustments to changed order of codecs in codec/cpu-dai property,
>  - fixed errors in snow_remove().
> ---
>  sound/soc/samsung/snow.c | 226 +++++++++++++++++++++++++++++++++++++----------
>  1 file changed, 178 insertions(+), 48 deletions(-)
>
> diff --git a/sound/soc/samsung/snow.c b/sound/soc/samsung/snow.c
> index fc62110f500f..f00ca1ca0171 100644
> --- a/sound/soc/samsung/snow.c
> +++ b/sound/soc/samsung/snow.c
> @@ -11,92 +11,207 @@
>   * General Public License for more details.
>   */
>
> +#include <linux/clk.h>
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
>  #include <linux/of.h>
>  #include <linux/of_device.h>
> -
> +#include <sound/pcm_params.h>
>  #include <sound/soc.h>
>
>  #include "i2s.h"
>
> -#define FIN_PLL_RATE           24000000
> +#define FIN_PLL_RATE           24000000UL

This change looks unrelated so how about making it separate patch?

For the rest:
Acked-by: Krzysztof Kozlowski <krzk at kernel.org>

Best regards,
Krzysztof


More information about the Alsa-devel mailing list