[alsa-devel] [PATCH] dt-bindings: exynos: Document #sound-dai-cells property of the HDMI node

[Sylwester Nawrocki]

On 03/09/2018 03:35 AM, Inki Dae wrote:
> 2018년 03월 08일 20:22에 Sylwester Nawrocki 이(가) 쓴 글:
>> On 03/08/2018 09:15 AM, Inki Dae wrote:
[...]
>>> Is there a possibility for other boards based on Exynos4210/4212/5420/5433 
>>> SoC to use this property later?
>>
>> All these SoCs have the HDMI IP block which has one input DAI, connected 
>> internally over I2S bus with the I2S controller.
>>
>> I think there is no advantage in limiting ourselves now only to SoC's 
>> for which we currently rely on that DT property in current kernel code, 
>> just to update this documentation later when we actually put the property 
>> in dts files.
>>
>> In case of exynos5420 we already require #sound-dai-cells for Odroid and
> 
> Maybe exynos5422? Odroid XU3/4 use Exynos5422.

Yes, my mistake, Exynos5422 for Odroid and Exynos5420 for Peach-Pit.
It just happens we use "samsung,exynos5420-hdmi" compatible for that both
SoCs.
 

> Seems that '#sound-dai-cells' is required mandatorily in case of Exynos5422 
> because Odroid XU3/4 Audio driver checks this property, and the driver 
> returns error if the property doesn't exist in its device tree.
> And if other SoCs - Exynos4210/4212/5250/5420/5433 - require this property 
> with additional driver works later then this property would also be required 
> mandatorily for them not optionally. In this case we may need to modify the 
> description again.
> 
> So my opinion is to add only the description required mandatorily if I 
> understood correctly.

You are right, it would be better to make this a mandatory property, I only
made it optional because now this property is missing in many dts files.
Let me resend with #sound-dai-cells description moved to the "Required 
properties" paragraph.

--
Thanks,
Sylwester