[alsa-devel] [PATCH 4/9] ALSA: usb-audio: use usb_fill_int_urb()

[Sergei Shtylyov]

Hello!

On 6/20/2018 12:55 AM, Sebastian Andrzej Siewior wrote:

> Using usb_fill_int_urb() helps to find code which initializes an
> URB. A grep for members of the struct (like ->complete) reveal lots
> of other things, too.
> 
> data_ep_set_params() additionally sets urb->transfer_buffer_length which
> was not the case earlier.
> data_ep_set_params() and data_ep_set_params()

    These 2 are the same function?

> ensure that syncinterval is
> within the allowed range on HS/SS. The interval value seems to come from
> snd_usb_parse_datainterval() which is bInterval - 1 and only in the rage 1 … 4.
> So in order to keep the magic wokring I pass datainterval + 1.

    Working.

> Cc: Jaroslav Kysela <perex at perex.cz>
> Cc: Takashi Iwai <tiwai at suse.com>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
[...]

MBR, Sergei