[alsa-devel] [PATCH v2 05/10] ASoC: wcd9335: add CLASS-H Controller support

[Mark Brown]

On Fri, Jul 27, 2018 at 01:18:01PM +0100, Srinivas Kandagatla wrote:

> +	res_val = WCD9XXX_CLASSH_CTRL_VCL_VREF_FILT_R_0KOHM;
> +	switch (mode) {
> +	case CLS_H_NORMAL:
> +		res_val = WCD9XXX_CLASSH_CTRL_VCL_VREF_FILT_R_50KOHM;
> +		val = WCD9XXX_A_ANA_HPH_PWR_LEVEL_NORMAL;
> +		gain = DAC_GAIN_0DB;
> +		ipeak = WCD9XXX_CLASSH_CTRL_CCL_1_DELTA_IPEAK_50MA;
> +		break;
> +	case CLS_AB:
> +		val = WCD9XXX_A_ANA_HPH_PWR_LEVEL_NORMAL;
> +		gain = DAC_GAIN_0DB;
> +		ipeak = WCD9XXX_CLASSH_CTRL_CCL_1_DELTA_IPEAK_50MA;
> +		break;
> +	case CLS_H_HIFI:
> +		val = WCD9XXX_A_ANA_HPH_PWR_LEVEL_UHQA;
> +		gain = DAC_GAIN_M0P2DB;
> +		ipeak = WCD9XXX_CLASSH_CTRL_CCL_1_DELTA_IPEAK_50MA;
> +		break;
> +	case CLS_H_LP:
> +		val = WCD9XXX_A_ANA_HPH_PWR_LEVEL_LP;
> +		ipeak = WCD9XXX_CLASSH_CTRL_CCL_1_DELTA_IPEAK_30MA;
> +		break;
> +	};

This is missing a default case for error checking, and you don't need
the semicolon at the end either.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20180731/067462ba/attachment.sig>