[alsa-devel] [PATCH v0 3/3] ASoC: max9867: Fix volume controls

[Mark Brown]

On Mon, Jul 30, 2018 at 12:45:03PM +0200, Ladislav Michl wrote:
> On Mon, Jul 30, 2018 at 11:11:15AM +0100, Mark Brown wrote:
> > On Sat, Jul 28, 2018 at 05:44:15PM +0200, Ladislav Michl wrote:
> > > Build proper audio paths and fix volume controls to match datasheet.

> > This sounds like it should be split up into separate patches for at
> > least the routing and volume control stuff.  It also needs a bit of a
> > better changelog as I'm not sure what the issues with the volume
> > controls were or what was improper about the old audio paths.

> Oh well, will do. Perhaps driver author wants to step in and describe
> setup driver was tested with. This is not meant as an offense, but
> it does really look like code was copied over from other drivers
> (sometimes without renaming) until it compiled and then submitted.
> As it is I'm unable to play or record anything as power domains
> are not enabled, but there still is a chance I'm doing something
> wrong.

It wouldn't be the first driver that was used mainly for one use case
and not fully tested, people don't always even have the hardware wired
up to cover everything and try to write things blind from the datasheet
for completeness.

> > >  I'm still unsure about control names, please see yet unaswered mail
> > >  here: https://www.spinics.net/lists/alsa-devel/msg80006.html

> > Always CC maintainers on mails - you really shouldn't rely on anyone
> > seeing anything that only goes to the lists, they're quite high volume.

> Well, in this case I decided to sent general question to the list in a
> hope anyone with enough knowledge could answer that... But point taken,
> will Cc maintaniners next time.

Yeah, it's good to send to the list in case someone else chimes in but
the copy to maintainers helps a lot still even for things that are just
discussions.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20180730/3c9e932a/attachment.sig>